Skip to content

Implement expand_kwargs() against a literal list#25925

Merged
uranusjr merged 4 commits into
apache:mainfrom
astronomer:aip-42-expand-kwargs-literal
Sep 1, 2022
Merged

Implement expand_kwargs() against a literal list#25925
uranusjr merged 4 commits into
apache:mainfrom
astronomer:aip-42-expand-kwargs-literal

Conversation

@uranusjr
Copy link
Copy Markdown
Member

This adds literal support to expand_kwargs():

task.expand_kwargs([{"arg": 1}, {"arg": 2}, ...])

# Literal list can contain either literal dict or XComArg.
task.expand_kwargs([xcom_arg, {"arg": 2}, ...])

This matches the expand() interface.

This needs #25924 to go in first and is submitted for CI now.

@ashb
Copy link
Copy Markdown
Member

ashb commented Aug 26, 2022

(Attempted to resolve conflicts vis GH, may not have worked out very well)

@uranusjr uranusjr force-pushed the aip-42-expand-kwargs-literal branch 2 times, most recently from e28341f to 2b7452e Compare August 28, 2022 17:04
The literal list may contain dict (operator kwargs) or an XComArg
(resolved to operator kwargs at runtime).
@uranusjr uranusjr force-pushed the aip-42-expand-kwargs-literal branch from 2b7452e to e28183d Compare August 29, 2022 08:11
Probably caused by rebasing.
@uranusjr uranusjr marked this pull request as ready for review August 29, 2022 17:12
@uranusjr uranusjr merged commit 4791443 into apache:main Sep 1, 2022
@uranusjr uranusjr deleted the aip-42-expand-kwargs-literal branch September 1, 2022 00:51
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Sep 13, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dynamic-task-mapping AIP-42 type:new-feature Changelog: New Features

3 participants