Skip to content

Add origin request args when triggering a run#25729

Merged
bbovenzi merged 2 commits into
apache:mainfrom
astronomer:fix-trigger-origin-params
Aug 17, 2022
Merged

Add origin request args when triggering a run#25729
bbovenzi merged 2 commits into
apache:mainfrom
astronomer:fix-trigger-origin-params

Conversation

@bbovenzi
Copy link
Copy Markdown
Contributor

Include the query parameters in the origin when manually triggering a dag run from the dag page. Prevents request errors when triggering a run from a task instance detail page and losing your place elsewhere the dag page.

Fixes: #24725


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 15, 2022
Comment thread airflow/www/templates/airflow/dag.html Outdated
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Copy link
Copy Markdown
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it fix the issue

@bbovenzi bbovenzi merged commit 69663b2 into apache:main Aug 17, 2022
@bbovenzi bbovenzi deleted the fix-trigger-origin-params branch August 17, 2022 13:21
@eladkal eladkal added this to the Airflow 2.4.0 milestone Aug 17, 2022
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Aug 17, 2022
@eladkal eladkal modified the milestones: Airflow 2.4.0, Airflow 2.3.5 Aug 26, 2022
@ashb ashb modified the milestones: Airflow 2.3.5, Airflow 2.4.0 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

4 participants