Check expand_kwargs() input type before unmapping#25355
Merged
uranusjr merged 3 commits intoJul 29, 2022
Conversation
uranusjr
commented
Jul 28, 2022
uranusjr
commented
Jul 28, 2022
Comment on lines
253
to
254
Member
Author
There was a problem hiding this comment.
This one shouldn’t be possible in theory since the upstream ensures the return value is list-like, but let’s check anyway.
ashb
approved these changes
Jul 28, 2022
potiuk
approved these changes
Jul 28, 2022
2 tasks
This was originally done when the value is pushed in upstream, but that was removed when we implemented map(), and now should be done when the value is pulled.
uranusjr
force-pushed
the
aip-42-expand-kwargs-runtime-type-check
branch
from
8181127 to
e35651b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally done when the value is pushed in upstream, but that was removed when we implemented
map(), and now should be done when the value is pulled. The task would have failed without these explicit checks, but with very cryptic error messages.Close #25352