Clean up task decorator type hints and docstrings#24667
Merged
Conversation
dstandish
approved these changes
Jun 28, 2022
github-actions
Bot
added
the
full tests needed
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
All those 'T' type vars are no longer needed since we've unified the typing long ago (all these functions now use the 'Function' type var). Also slightly fixed up task.branch to match the styles of other task decorators.
uranusjr
force-pushed
the
decorator-typing-cleanup
branch
from
29f95c7 to
9773c04
Compare
uranusjr
force-pushed
the
decorator-typing-cleanup
branch
from
9773c04 to
be92a39
Compare
ephraimbuddy
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All those 'T' type vars are no longer needed since we've unified the
typing long ago (all these functions now use the 'Function' type var).
Also slightly fixed up task.branch to match the styles of other
task decorators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.