Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

feat(@schematics/angular): service worker project generation #235

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Oct 23, 2017

This adds a feature to the Angular application schematic to generate a
project which includes @angular/service-worker's ServiceWorkerModule,
conditionally enabled for production builds. An ngsw.json file with
configuration suited for most projects is also generated.

Both operations are gated on the --service-worker flag which is added.

@alxhub alxhub requested a review from Brocco October 23, 2017 16:20
@alxhub alxhub force-pushed the service-worker branch 3 times, most recently from e9db624 to 1e28d34 Compare October 25, 2017 19:36
@webmaxru
Copy link
Member

It would be cool to have the configuration file name different from control file name, for example ngsw-config.json

@alxhub alxhub force-pushed the service-worker branch 2 times, most recently from ead024f to 0c204e2 Compare October 30, 2017 17:26
This adds a feature to the Angular application schematic to generate a
project which includes @angular/service-worker's ServiceWorkerModule,
conditionally enabled for production builds. An ngsw.json file with
configuration suited for most projects is also generated.

Both operations are gated on the --service-worker flag which is added.
@hansl hansl merged commit a54adc9 into angular:master Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 participants