Skip to content

Added data connect to schematics #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 6 commits into from
Apr 7, 2025
Merged

Added data connect to schematics #3638

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0855dff
Added data connect to schematics
maneesht Mar 12, 2025
88d8fbb
Remove alpha version
maneesht Apr 7, 2025
7c11d82
Removed todo
maneesht Apr 7, 2025
837c20c
Fix provide dataconnect
maneesht Apr 7, 2025
d73b7ec
Fixed packages
maneesht Apr 7, 2025
c0c17c3
Updated logs
maneesht Apr 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix provide dataconnect
  • Loading branch information
@maneesht
maneesht committed Apr 7, 2025
commit 837c20cf82d29dd97a1b7c604065a154a60b8d51
11 changes: 6 additions & 5 deletions src/schematics/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export function featureToRules(
}
}
return code`${external(
"provideDataConnectQuery",
"provideDataConnect",
"@angular/fire/data-connect"
)}(() => getDataConnect(${configAsStr}))${angularConfig ?? ""}`;
});
Expand Down Expand Up @@ -386,13 +386,14 @@ export function setupTanstackDependencies(
context: SchematicContext
) {
const packageJson: PackageJson = safeReadJSON("package.json", host);
const tanstackFirebasePackage = "@tanstack-query-firebase/angular";
if (
!packageJson.dependencies["@tanstack-query-firebase/angular"] &&
!packageJson.devDependencies["@tanstack-query-firebase/angular"]
!packageJson.dependencies[tanstackFirebasePackage] &&
!packageJson.devDependencies[tanstackFirebasePackage]
) {
packageJson.dependencies["@tanstack-query-firebase/angular"] =
packageJson.dependencies[tanstackFirebasePackage] =
"^1.0.0";
packageJson.dependencies["@tanstack/angular-query-experimental"] = "5.66.4";
packageJson.dependencies[tanstackFirebasePackage] = "5.66.4";
overwriteIfExists(host, "package.json", stringifyFormatted(packageJson));
context.addTask(new NodePackageInstallTask());
}
Expand Down