Skip to content

feat(@angular/cli): support 5.0.0+ builds of @angular/service-worker #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Oct 17, 2017

No description provided.

@alxhub
Copy link
Member Author

alxhub commented Oct 18, 2017

This will likely have issues on Windows until Angular 5.0.0-rc.3 is released, due to angular/angular@621f87b.

@StephenFluin
Copy link
Contributor

StephenFluin commented Oct 18, 2017

It throws an error when I don't have an ngsw.json file in src, is that intentional or am I doing something wrong? Perhaps it could warn the user and link them to an example file?

return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
               ^
Error: ENOENT: no such file or directory, open '/path/to/project/src/ngsw.json'
@alxhub alxhub force-pushed the sw-support branch 3 times, most recently from e7ded45 to 4b2641a Compare October 20, 2017 16:32
@alxhub
Copy link
Member Author

alxhub commented Oct 20, 2017

I added an explicit error if the file is not found, @StephenFluin :)

@alxhub alxhub force-pushed the sw-support branch 6 times, most recently from 25da5be to 59a8136 Compare October 23, 2017 17:22
@ivancamilov
Copy link

we're on 5.0.0-rc.5, so this should work on Windows now. Hopefully this can be merged soon.

@hansl hansl merged commit 7b4b2c7 into angular:master Nov 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants