Skip to content

Remove Dv2 Null checks #31149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Edward Gao (edgao) merged 22 commits into from
Oct 10, 2023
Merged

Remove Dv2 Null checks #31149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5c11a74
wip
evantahler Oct 6, 2023
9a9fa94
wip
evantahler Oct 6, 2023
a6ff675
Automated Commit - Formatting Changes
evantahler Oct 6, 2023
9b5f40d
WIP + testing
evantahler Oct 6, 2023
b6df944
Automated Commit - Formatting Changes
evantahler Oct 6, 2023
3a855de
SQLException
evantahler Oct 9, 2023
0c2aa58
new tests pass
evantahler Oct 9, 2023
9e92833
Automated Commit - Formatting Changes
evantahler Oct 9, 2023
973753d
delete null-checking test
evantahler Oct 9, 2023
9a799f3
Merge branch 'master' into evan/remove-null-checks
evantahler Oct 9, 2023
a97b02e
Metadata
evantahler Oct 9, 2023
0f364df
remove incrementalDedupInvalidPrimaryKey
evantahler Oct 9, 2023
0a15c04
Automated Commit - Formatting Changes
evantahler Oct 9, 2023
289bd75
Add integration tests
evantahler Oct 9, 2023
effe904
Automated Commit - Formatting Changes
evantahler Oct 10, 2023
48b09ff
tests passing
evantahler Oct 10, 2023
e1f062b
Automated Commit - Formatting Changes
evantahler Oct 10, 2023
e275b0b
Merge branch 'master' into evan/remove-null-checks
edgao Oct 10, 2023
2cc01f4
minor tweaks
edgao Oct 2, 2023
3e06a29
add comment
edgao Oct 10, 2023
b46a3f1
typo
edgao Oct 10, 2023
7a909cc
Automated Commit - Formatting Changes
edgao Oct 10, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Automated Commit - Formatting Changes
  • Loading branch information
@evantahler @octavia-squidington-iii
evantahler authored and octavia-squidington-iii committed Oct 9, 2023
commit 0a15c0495400429d5745b021d2693a3aa1a4b187
2 changes: 1 addition & 1 deletion ...irbyte/integrations/base/destination/typing_deduping/BaseSqlGeneratorIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ public void detectColumnChanged() throws Exception {
generator.existingSchemaMatchesStreamConfig(incrementalDedupStream, existingTable.get()),
"Altering a column was not detected as a schema change.");
}

/**
* Test that T+D supports streams whose name and namespace are the same.
*/
Expand Down
3 changes: 0 additions & 3 deletions ...egrations/destination/snowflake/typing_deduping/SnowflakeSqlGeneratorIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@
package io.airbyte.integrations.destination.snowflake.typing_deduping;

import static io.airbyte.integrations.destination.snowflake.SnowflakeTestUtils.timestampToString;
import static java.util.Collections.emptyList;
import static java.util.stream.Collectors.joining;
import static java.util.stream.Collectors.toMap;
import static org.junit.jupiter.api.Assertions.assertAll;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import autovalue.shaded.com.google.common.collect.ImmutableMap;
import com.fasterxml.jackson.databind.JsonNode;
Expand Down