-
Notifications
You must be signed in to change notification settings - Fork 5k
Source iterable: fix pendulum.parse memory leak #19913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sergey Chvalyuk <[email protected]>
Signed-off-by: Sergey Chvalyuk <[email protected]>
Signed-off-by: Sergey Chvalyuk <[email protected]>
Signed-off-by: Sergey Chvalyuk <[email protected]>
|
/test connector=connectors/source-iterable
Build PassedTest summary info: |
airbyte-integrations/connectors/source-iterable/source_iterable/utils.py
Show resolved
Hide resolved
Signed-off-by: Sergey Chvalyuk <[email protected]>
|
/publish connector=connectors/source-iterable
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Signed-off-by: Sergey Chvalyuk [email protected]
What
Try to fix https://github.com/airbytehq/oncall/issues/1115
pendulum.parse(, strict=False)- leaks memoryAfter 100000 calls RSS memory 20056 kBs
After 1000000 calls RSS memory 138328 kBs
How
Replace
pendulumondateutilRecommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.