Skip to content

Draft: Fix API URL on GHES#437

Closed
joshmgross wants to merge 11 commits into
mainfrom
joshmgross/fix-base-url
Closed

Draft: Fix API URL on GHES#437
joshmgross wants to merge 11 commits into
mainfrom
joshmgross/fix-base-url

Conversation

@joshmgross
Copy link
Copy Markdown
Contributor

@joshmgross joshmgross commented Nov 16, 2023 •
edited
Loading

#436

Attempting to reproduce the issue described in #436, and then I will push a change to actually fix it.

- Validating base-url not set respects GITHUB_API_URL
Error: ❌ Expected base-url to equal 'https://my.github-enterprise-server.com/api/v3/', got https://api.github.com/
Error: Process completed with exit code 1.

https://github.com/actions/github-script/actions/runs/6893610162/job/18753569096?pr=437
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:16 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 16, 2023 •
edited
Loading

Hello from actions/github-script! (9a202b7)
@joshmgross joshmgross force-pushed the joshmgross/fix-base-url branch from babde17 to 4793596 Compare November 16, 2023 16:20
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:20 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:24 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:26 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:28 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:33 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:37 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:38 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 16:43 — with GitHub Actions Inactive
@joshmgross joshmgross mentioned this pull request Nov 16, 2023
Closed
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 23:49 — with GitHub Actions Inactive
@joshmgross joshmgross temporarily deployed to debug-integration-test November 16, 2023 23:51 — with GitHub Actions Inactive
@joshmgross joshmgross changed the title Draft: Fix base-url overriding GITHUB_API_URL Draft: Fix API URL on GHES Nov 16, 2023
@joshmgross joshmgross temporarily deployed to debug-integration-test November 17, 2023 15:20 — with GitHub Actions Inactive
@joshmgross joshmgross mentioned this pull request Nov 17, 2023
Merged
@joshmgross
Copy link
Copy Markdown
Contributor Author

joshmgross commented Nov 17, 2023

#439 is shipping this fix and removing the failing integration test, we were able to confirm it works in #436
@joshmgross joshmgross closed this Nov 17, 2023
@joshmgross joshmgross deleted the joshmgross/fix-base-url branch November 17, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@joshmgross