Correct: Since for webp_uploads_generate_additional_image_source()#362
Merged
Conversation
Contributor
|
Thanks @mukeshpanchal27! Note that per the checklist in the PR template, all PRs require:
I've added these on this PR, but please make sure you have these added on future PRs as they will not pass tests unless these requirements are met. There are more details on each of the label types in our Handbook if you need them. Thanks! |
felixarntz
approved these changes
Jun 13, 2022
Member
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Great catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webp_uploads_generate_additional_image_source()introduce in version1.0.0in the plugin but it still shows@since n.e.xtbecause of it has text issue. This version change is part of the release process that happens on the day of the release as per https://github.com/WordPress/performance/blob/trunk/docs/Releasing-the-plugin.md#preparing-the-release document.This PR set the version number to
1.0.0Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.