Skip to content

Move admin to includes directory#1072

Merged
felixarntz merged 5 commits into
trunkfrom
enhancement/move-admin-to-includes
Mar 21, 2024
Merged

Move admin to includes directory#1072
felixarntz merged 5 commits into
trunkfrom
enhancement/move-admin-to-includes

Conversation

@thelovekesh
Copy link
Copy Markdown
Member

@thelovekesh thelovekesh commented Mar 21, 2024 •
edited
Loading

Summary

Previously #1042

As discussed in #1029 (comment), we discussed moving the top-level PL plugin code to the includes directory. In #1042 we already moved the site-health and server-timing to the includes directory but it seems like the admin directory was not moved to the right place. This PR aims to do that.
@thelovekesh thelovekesh requested a review from westonruter March 21, 2024 16:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@thelovekesh thelovekesh added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Mar 21, 2024
@thelovekesh thelovekesh added the no milestone PRs that do not have a defined milestone for release label Mar 21, 2024
westonruter
westonruter approved these changes Mar 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@felixarntz felixarntz added this to the performance-lab 3.0.0 milestone Mar 21, 2024
@felixarntz felixarntz added skip changelog PRs that should not be mentioned in changelogs and removed no milestone PRs that do not have a defined milestone for release labels Mar 21, 2024
felixarntz
felixarntz approved these changes Mar 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks @thelovekesh!
@felixarntz felixarntz merged commit 84762da into trunk Mar 21, 2024
@felixarntz felixarntz deleted the enhancement/move-admin-to-includes branch March 21, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature

3 participants

@thelovekesh @westonruter @felixarntz