-
Notifications
You must be signed in to change notification settings - Fork 148
Revisit how we handle object-cache.php conflicts #630
Copy link
Copy link
Closed
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Type] BugAn existing feature is brokenAn existing feature is broken
Milestone
Metadata
Metadata
Assignees
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Type] BugAn existing feature is brokenAn existing feature is broken
Type
Fields
Give feedbackNo fields configured for issues without a type.
Bug Description
Based on one users testing with the plugin when also using Redis Object Caching pro, Redis Cache pro is disabled when it determines an object-cache.php file present that isn't generated from Redis Object Caching pro. All the features of Redis Cache Pro are disabled when it comes across a non Redis Cache Pro object-cache file.
While it's possible any resolution on this may be applicable on the Redis Object Cache pro side, it may be an opportunity to check how the plugin handles such conflicts. At present we're moving the contents of a third party plugins
object-cach.phpfile toobject-cache-plst-orig.php, and then requesting that within the footer of the PL placedobject-cache.phpfile. Maybe there's another way of using a third party caching plugin alongside the PL object-cache.php file.Note also that we did make changes recently (PR #616) to resolve issues with third party plugin caching file contents being added to both the
object-cache.phpandobject-cache-plst-orig.phpfiles.There is also an existing PL GitHub issue specific to Redis Cache Pro which, once actioned will provide a solution.
Steps to reproduce
object-cache.phpfile contents to ensure the PL plugin has overwritten the existingobect-cachefile (while moving the existing one toobject-cache-plst-orig.phpScreenshots