-
Notifications
You must be signed in to change notification settings - Fork 148
Enqueued scripts should use plugins_url() instead of plugin_dir_url() #1647
Copy link
Copy link
Closed
Copy link
Labels
Good First IssueIssue particularly suitable to be worked on by new contributorsIssue particularly suitable to be worked on by new contributors[Plugin] Embed OptimizerIssues for the Embed Optimizer plugin (formerly Auto Sizes)Issues for the Embed Optimizer plugin (formerly Auto Sizes)[Plugin] Optimization DetectiveIssues for the Optimization Detective pluginIssues for the Optimization Detective plugin[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Plugin] Web Worker OffloadingIssues for the Web Worker Offloading plugin.Issues for the Web Worker Offloading plugin.[Type] EnhancementA suggestion for improvement of an existing featureA suggestion for improvement of an existing feature
Metadata
Metadata
Assignees
Labels
Good First IssueIssue particularly suitable to be worked on by new contributorsIssue particularly suitable to be worked on by new contributors[Plugin] Embed OptimizerIssues for the Embed Optimizer plugin (formerly Auto Sizes)Issues for the Embed Optimizer plugin (formerly Auto Sizes)[Plugin] Optimization DetectiveIssues for the Optimization Detective pluginIssues for the Optimization Detective plugin[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Plugin] Web Worker OffloadingIssues for the Web Worker Offloading plugin.Issues for the Web Worker Offloading plugin.[Type] EnhancementA suggestion for improvement of an existing featureA suggestion for improvement of an existing feature
Type
Fields
Give feedbackNo fields configured for Enhancement.
Projects
Status
Done 😃
Feature Description
When the URLs for JS files are generated in the plugins, the
plugin_dir_url()function is used. Its output is concatenated with the relative path:performance/plugins/optimization-detective/detection.php
Line 82 in 5fbd82e
However, this is not ideal because the resulting URL is not directly filterable. It would be better to use
plugins_url():In this way, the
plugins_urlfilter can be used to potentially rewrite the URL to point to a CDN, for example.See instances: https://github.com/search?q=repo%3AWordPress%2Fperformance%20%2Fplugin_dir_url%5C(%2F&type=code