Skip to content

Ensure the tests can pass by ignoring two license checks.#86

Closed
whyisjake wants to merge 7 commits into
trunkfrom
license-check-update
Closed

Ensure the tests can pass by ignoring two license checks.#86
whyisjake wants to merge 7 commits into
trunkfrom
license-check-update

Conversation

@whyisjake
Copy link
Copy Markdown
Member

--ignore=language-subtag-registry,tslib

ERROR Module language-subtag-registry has an incompatible license 'ODC-By-1.0'.
ERROR Module tslib has an incompatible license '0BSD'.

--ignore=language-subtag-registry,tslib

 ERROR  Module language-subtag-registry has an incompatible license 'ODC-By-1.0'.ERROR  Module tslib has an incompatible license '0BSD'.
@whyisjake
Copy link
Copy Markdown
Member Author

(I am not a lawyer)

These licenses look pretty permissive, but I don't see them here: https://www.gnu.org/licenses/license-list.en.html

@aaronjorbin
Copy link
Copy Markdown
Member

0BSD looks fine, it's largely the same as ISC
ODC-By-1.0 is less clear to me

@whyisjake
Copy link
Copy Markdown
Member Author

Looks like the actual script is MIT licensed, but the database is ODC-By-1.0.

Update scripts copyright (c) 2013, Matthew Caruana Galizia and licensed under and MIT license.
The JSON database is licensed an Open Data Commons Attribution License (ODC-BY).

https://github.com/mattcg/language-subtag-registry

@whyisjake
Copy link
Copy Markdown
Member Author

Opened an issue over here too: mattcg/language-subtag-registry#7

@jeffpaul
Copy link
Copy Markdown
Member

jeffpaul commented Jul 9, 2020

Some questions from @Otto42 to help guide us here:

  • What is language-subtag-registry and how is it used?
  • Is this specific to data or code?
@whyisjake
Copy link
Copy Markdown
Member Author

Really, this should be moved upstream, here.

@whyisjake
Copy link
Copy Markdown
Member Author

Added a PR here to include ODC-By-1.0.

WordPress/gutenberg#23851

@ntwb
Copy link
Copy Markdown
Member

ntwb commented Jul 10, 2020

Added a PR here to include ODC-By-1.0.

WordPress/gutenberg#23851

✅ Approved

Not sure when the next release of Gutenberg packages will be though

@whyisjake
Copy link
Copy Markdown
Member Author

Need the @wordpress/scripts release done, and then we can bump the version there.

@whyisjake
Copy link
Copy Markdown
Member Author

Merged in #89. 📦 🥳

@whyisjake whyisjake closed this Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants