fix: open each post as its own window from the Posts window#176
Merged
Conversation
`post.php?post=X&action=edit` URLs collapsed to a single window ID (`post-php`) because `post` wasn't in `IDENTITY_PARAMS`. Clicking a second post in the Posts list refocused the first post's window instead of opening the new one. Add `post` to `IDENTITY_PARAMS` so each post's edit URL derives a distinct window ID, and add a regression test.
Contributor
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a second post in the Posts window refocused the first post's window instead of opening a new one.
deriveWindowId()collapsed everypost.php?post=X&action=editURL to the same ID (post-php) becausepostwasn't inIDENTITY_PARAMS— onlypost_type,page,taxonomy, andpathwere significant. So every post-edit URL produced the same window ID, andwindowManager.open()saw a matching window and refocused it.Fix
Add
posttoIDENTITY_PARAMSsopost.php?post=123&action=edit→post-php-post-123andpost.php?post=456&action=edit→post-php-post-456. Every code path that derives a window ID (Posts-window row click viaopenAdminUrl, in-shell<a href>clicks via the link interceptor, dock-icon clicks, session restore, geometry lookups) benefits automatically since they all funnel throughderiveWindowId.Test plan
npm run lint,tsc --noEmit, fullvitest(1116 tests) greentests/vitest/utils.test.tslocks in distinct IDs for two post URLs