Implement favicon resolver and associated tests for desktop mode#139
Merged
Conversation
- Added `desktop_mode_resolve_favicon` function to resolve favicons from URLs, including handling various HTML link tags and fallback mechanisms. - Introduced a new PHP file `favicon.php` for favicon resolution logic. - Created unit tests for the favicon resolver in `desktopFilesFavicon.php`, covering various scenarios including successful resolution, fallback cases, and error handling. - Updated the wallpaper menu tests to include a new URL creation option and its corresponding functionality. - Added Vitest tests for tile rendering and icon handling, ensuring correct rendering of data URIs and fallback behaviors. - Implemented REST API tests for link placements, verifying that the favicon resolver integrates correctly with the placement creation process.
Contributor
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desktop_mode_resolve_faviconfunction to resolve favicons from URLs, including handling various HTML link tags and fallback mechanisms.favicon.phpfor favicon resolution logic.desktopFilesFavicon.php, covering various scenarios including successful resolution, fallback cases, and error handling.