Skip to content

update wporg assets#546

Open
jeffpaul wants to merge 7 commits into
developfrom
update/wporg-assets
Open

update wporg assets#546
jeffpaul wants to merge 7 commits into
developfrom
update/wporg-assets

Conversation

@jeffpaul
Copy link
Copy Markdown
Member

@jeffpaul jeffpaul commented May 13, 2026

What?

Closes #513.

Follow up to WordPress/gutenberg#78243 (comment).

Why?

How?

Use of AI Tools

Testing Instructions

Screenshots or screencast

Before After

Changelog Entry

Changed - Updated plugin banner and icons.

Open WordPress Playground Preview
Co-Authored-By: Tammie Lister <253067+karmatosed@users.noreply.github.com>
Co-Authored-By: Shaun Andrews <shaun@automattic.com>
Co-Authored-By: Juan Aldasoro <252415+juanfra@users.noreply.github.com>
@jeffpaul jeffpaul added this to the 1.0.0 milestone May 13, 2026
@jeffpaul jeffpaul requested a review from dkotter May 13, 2026 18:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: karmatosed <karmatosed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.21%. Comparing base (351ffbd) to head (8081836).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #546   +/-   ##
==========================================
  Coverage      71.21%   71.21%           
  Complexity      1151     1151           
==========================================
  Files             67       67           
  Lines           5565     5565           
==========================================
  Hits            3963     3963           
  Misses          1602     1602           
Flag Coverage Δ
unit 71.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Copy link
Copy Markdown
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but noting there are other places that use the icon that this PR doesn't update, at least:

  1. Icon shown in the header of the AI settings page
  2. Icon used in the block toolbar for the Content Resizing feature
@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented May 13, 2026

I quickly tested locally by just copying the SVG markup into our ai-icon.tsx file but this new icon doesn't work great at the smaller size we show in the admin. Ends up looking blurry/pixelated, which I realize the icon does that on purpose but doesn't work great at small scale:

New AI icon on settings page New AI icon in block toolbar

Now maybe this is a mistake on my end and there's a "better" way to pull that SVG markup into our icon file that would resolve this. But wondering if we need a solid line version of the icon to use in the admin?

@jeffpaul
Copy link
Copy Markdown
Member Author

@karmatosed perhaps an alt version that appears better that these lower resolutions/sizes?

@karmatosed
Copy link
Copy Markdown
Member

karmatosed commented May 15, 2026

I tried to make it work smaller but it doesn't so lets just use the original one smaller simplified.

smallsize
@jeffpaul
Copy link
Copy Markdown
Member Author

@dkotter are you able to try that ^ image in the settings page and block toolbar?

@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented May 15, 2026

Does look better but the old icon was 24x24 and this one is 132x184. Would be great if it was the same size or at least a 1:1 ratio, otherwise it doesn't match other icons, in particular in the block toolbar:

New AI icon in block toolbar
@karmatosed
Copy link
Copy Markdown
Member

karmatosed commented May 18, 2026

I couldn't get exact square so maybe...
ratio

I actually think the border might be better to be a true 1:1
Frame 9

@jeffpaul jeffpaul mentioned this pull request May 18, 2026
32 tasks
@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented May 18, 2026

So this looks better though the border does make it stand out more as compared to other block toolbar icons.

The main issue that I need help on (someone that's better with SVG and CSS) is that this SVG has inline fill attributes and that overrides the styling that is automatically added to the block toolbar. So if you hover over the icon there, it should get a blue fill color but that's not working. Same with blocks that have previously been resized using AI, the toolbar icon should default to blue but that's no longer working. I've tried a few CSS tweaks but haven't found one that full resolves it.

Screenshot 2026-05-18 at 2 58 11 PM Screenshot 2026-05-18 at 2 58 21 PM
@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented May 18, 2026

The main issue that I need help on (someone that's better with SVG and CSS) is that this SVG has inline fill attributes and that overrides the styling that is automatically added to the block toolbar

Tried a few other approaches and finally found one that seems to more or less fix the problem so just pushed that up. This is looking good to me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants