Skip to content

[Fix]: Meta Description Experiment | ensure_text_generation_supported#465

Merged
dkotter merged 6 commits into
WordPress:developfrom
TylerB24890:fix/meta-description-is-supported
Apr 24, 2026
Merged

[Fix]: Meta Description Experiment | ensure_text_generation_supported#465
dkotter merged 6 commits into
WordPress:developfrom
TylerB24890:fix/meta-description-is-supported

Conversation

@TylerB24890
Copy link
Copy Markdown
Contributor

@TylerB24890 TylerB24890 commented Apr 23, 2026

What?

Follow up to: https://github.com/WordPress/ai/pull/331/changes/BASE..c36de00bded0ed62f6547d8955cb2d1d2c28126b#r3112870157

This PR implements the Abstract_Ability::ensure_text_generation_supported() method into the Meta Description experiment get_prompt_builder() method.

NOTE: Also updates the @since tags as the placeholder x.x.x values were still present in the develop branch.

Why?

The ensure_text_generation_supported() method is the Ability standard way of verifying a models capability for generating the experiment output. It's best to re-use existing methods for compatibility rather than re-inventing the wheel.

How?

Replace the custom $builder->is_text_generation_supported() method with the abstract ensure_text_generation_supported() method.

Use of AI Tools

N/A

Changelog Entry

Added - New feature.
Changed - Existing functionality.
Deprecated - Soon-to-be removed feature.
Removed - Feature.
Fixed - Bug fix.
Security - Vulnerability.
Development Update - Development related updates.

Fixed - standards compliance.

Open WordPress Playground Preview
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: TylerB24890 <tyb@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.07%. Comparing base (6ecf7da) to head (d11740c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #465   +/-   ##
==========================================
  Coverage      69.06%   69.07%           
+ Complexity       958      957    -1     
==========================================
  Files             60       60           
  Lines           4513     4511    -2     
==========================================
- Hits            3117     3116    -1     
+ Misses          1396     1395    -1     
Flag Coverage Δ
unit 69.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@dkotter dkotter added this to the 0.9.0 milestone Apr 23, 2026
Comment thread includes/Abilities/Meta_Description/Meta_Description.php Outdated
dkotter and others added 5 commits April 23, 2026 14:53
Bumps the github-actions-updates group with 1 update: [actions/setup-node](https://github.com/actions/setup-node).


Updates `actions/setup-node` from 6.3.0 to 6.4.0
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@53b8394...48b55a0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: 6.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-version: 2.1.49
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: composer-dev-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@TylerB24890 TylerB24890 requested a review from dkotter April 24, 2026 13:18
@dkotter dkotter merged commit 1a55305 into WordPress:develop Apr 24, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants