change the order of summary and quantile(s)#105
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 12 12
Lines 1643 1643
=======================================
Hits 1439 1439
Misses 153 153
Partials 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@makasim I re-think about using And my point here is that, only Summary (and quantiles) need this sorting function, and if new function added for the metric interface, this function is not useful for other implementations, except Summary and quantiles. |
I am fine with it. Just make sure it is properly commented. So we won't forget these details in a month. |
Co-authored-by: Max Kotliar <mkotlyar@victoriametrics.com>
Restore sorting order of summary and quantile metrics exposed by VictoriaMetrics components on `/metrics` page. VictoriaMetrics/metrics#105 Signed-off-by: hagen1778 <roman@victoriametrics.com>
Restore sorting order of summary and quantile metrics exposed by VictoriaLogs components on `/metrics` page. VictoriaMetrics/metrics#105
Restore sorting order of summary and quantile metrics exposed by VictoriaTraces components on `/metrics` page. VictoriaMetrics/metrics#105
Restore sorting order of summary and quantile metrics exposed by VictoriaTraces components on `/metrics` page. VictoriaMetrics/metrics#105
Restore sorting order of summary and quantile metrics exposed by VictoriaMetrics components on `/metrics` page. VictoriaMetrics/metrics#105 Signed-off-by: hagen1778 <roman@victoriametrics.com>
Restore sorting order of summary and quantile metrics exposed by VictoriaMetrics components on `/metrics` page. VictoriaMetrics/metrics#105 Signed-off-by: hagen1778 <roman@victoriametrics.com> (cherry picked from commit cd52978)
|
The bugfix has been included in VictoriaLogs v1.36.0. |
This is a follow-up to #99.
Prior to #99, the order of summary metrics (
_sumand_count) and quantiles could vary depending on the metric name.After #99, the order was fixed to show summaries first, followed by quantiles. This ordering was based on the author's tests, but at the time, the author was unaware that different orders were possible.
In conclusion:
Therefore, this pull request modifies the sorting logic for summaries and quantiles, enforcing that quantiles are printed first, followed by summaries.