Conversation
AndrewChubatiuk
force-pushed
the
splunk
branch
4 times, most recently
from
0fb01c9 to
77ab347
Compare
AndrewChubatiuk
force-pushed
the
splunk
branch
4 times, most recently
from
9005319 to
43b45c8
Compare
Contributor
Author
|
@valyala could you please take a look at this PR? |
AndrewChubatiuk
force-pushed
the
splunk
branch
6 times, most recently
from
351d07f to
972e4b0
Compare
vadimalekseev
approved these changes
Feb 11, 2026
Member
vadimalekseev
left a comment
vadimalekseev
left a comment
There was a problem hiding this comment.
Looks good! Left some minor comments
AndrewChubatiuk
force-pushed
the
splunk
branch
from
972e4b0 to
a1d5ac3
Compare
func25
reviewed
Feb 11, 2026
AndrewChubatiuk
force-pushed
the
splunk
branch
from
a1d5ac3 to
bbc8e7b
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 16 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="app/vlinsert/datadog/datadog.go">
<violation number="1" location="app/vlinsert/datadog/datadog.go:38">
P3: Metrics path labels still reference "/insert/datadog/api/v2/logs" even though the handler now serves "/api/v2/logs", so observability will be misleading. Update the metric path labels to match the new endpoint.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
AndrewChubatiuk
force-pushed
the
splunk
branch
from
9fb3d01 to
a083555
Compare
func25
reviewed
Feb 11, 2026
AndrewChubatiuk
force-pushed
the
splunk
branch
from
a083555 to
ec1c936
Compare
AndrewChubatiuk
force-pushed
the
splunk
branch
2 times, most recently
from
f1d54e5 to
202f095
Compare
AndrewChubatiuk
force-pushed
the
splunk
branch
3 times, most recently
from
665dda7 to
7ccd80d
Compare
valyala
approved these changes
Apr 14, 2026
Contributor
|
@AndrewChubatiuk , thank you for implementing data ingestion for Splunk agent at VictoriaLogs! |
valyala
added a commit
that referenced
this pull request
Apr 14, 2026
- Clarify the description for -splunk.* command-line flags - Clarify the docs at https://docs.victoriametrics.com/victorialogs/data-ingestion/splunk/ - Add descriptions for Splunk-related command-line flags to VictoriaMetrics docs. - Consistently use 'Splunk' instead of 'splunk' across the docs. - Verify the correctness of stream field names passed via -splunk.streamFields command-line flags. - Clarify the error message when -splunk.tenantID command-line flag cannot be parsed, so users could understand how to fix the error. - Add missing docs for JSONScanner. - Fix errors in docs for commonJSON. - Properly reset JSONScanner.err on JSONScanner.reset() call. - Return back the order of parseLogMessage() args, because it was changed without real need. - Add a link to Splunk data ingestion docs at https://docs.victoriametrics.com/victorialogs/data-ingestion/ - Add a CHANGELOG line about the addition of the support for Splunk data ingestion protocol. Updates #710
Contributor
|
@AndrewChubatiuk , please see the follow-up commit 1b71b92 . |
Contributor
|
FYI, this pull request has been included in VictoriaLogs v1.50.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
-splunk.*cmd arguments were addedChecklist
The following checks are mandatory: