Skip to content

Add default flush_immediately config#37

Merged
mlpierce22 merged 3 commits into
mainfrom
codex/add-flush_immediately-to-config-scaffold
Jul 22, 2025
Merged

Add default flush_immediately config#37
mlpierce22 merged 3 commits into
mainfrom
codex/add-flush_immediately-to-config-scaffold

Conversation

@mlpierce22

Copy link
Copy Markdown
Contributor

Summary

  • add flush_immediately to scaffold config
  • load and default flush_immediately in Python, TypeScript and Go SDKs
  • set env var in Go collect
  • update TypeScript tests
  • update docs to mention flush_immediately default is now true

Testing

  • python3 scripts/run_tests_simple.py
  • poetry run ruff check sdk/python/trainloop_llm_logging
  • npm run build (fails: docker not found)

https://chatgpt.com/codex/tasks/task_e_687ddef0fb4c8324a54a5f64d225384e

@delve-auditor

delve-auditor Bot commented Jul 21, 2025

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 005e540.

Security Overview
  • 🔎 Scanned files: 16 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► sdk/python/trainloop_llm_logging/config.py
    Add flush_immediately config option
► sdk/python/trainloop_llm_logging/types.py
    Add flush_immediately to TrainLoopConfigObject
► sdk/python/trainloop_llm_logging/register.py
    Update collect() to handle flush_immediately parameter
► sdk/typescript/src/types/shared.d.ts
    Add flush_immediately to TrainloopConfig type
► sdk/typescript/src/config.ts
    Add flush_immediately config handling
► sdk/typescript/src/index.ts
    Update collect() to use flush_immediately
Refactor ► sdk/python/tests/integration/
    Migrate to pytest-based integration tests
► sdk/python/run_integration_tests.py
    Remove standalone test runner
Configuration changes ► examples/*/trainloop/trainloop.config.yaml
    Add flush_immediately flag
► sdk/go/trainloop-llm-logging/internal/types/types.go
    Add FlushImmediately field

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@mlpierce22

Copy link
Copy Markdown
Contributor Author

@claude can you rebase this branch?

@claude

claude Bot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Claude finished @mlpierce22's task —— View job


I'll help you with the rebase request!

Todo List

  • Check current git status and branch state
  • Analyze rebase requirements
  • Provide guidance on next steps

Analysis

I've analyzed the current branch state and found that:

  • Current branch: codex/add-flush_immediately-to-config-scaffold
  • Branch status: Multiple commits ahead of main (starting from b0bb605)
  • Main branch: Has a newer commit 9ab2091 feat: add upgrade command and expand SDK host allowlist (#35)
  • Rebase needed: Yes, to incorporate the latest changes from main

Limitation

I'm unable to perform rebase operations due to my current capabilities. I can only perform basic git operations like:

  • git add (staging files)
  • git commit (committing changes)
  • git push (pushing to remote)
  • git status, git diff (viewing status)

I cannot perform: git rebase, git merge, or other advanced branch operations.

Recommended Approach

You can rebase this branch yourself using one of these methods:

Option 1: Command Line Rebase

git checkout codex/add-flush_immediately-to-config-scaffold
git fetch origin
git rebase origin/main
# Resolve any conflicts if they arise
git push --force-with-lease origin codex/add-flush_immediately-to-config-scaffold

Option 2: GitHub UI

You can also use GitHub's "Update branch" button in the PR interface if there are no conflicts.

What I Can Help With

If there are any merge conflicts after you rebase, or if you need help with:

  • Reviewing the changes in this PR
  • Testing the flush_immediately configuration
  • Fixing any issues that arise after the rebase
  • Making additional code changes

Just let me know and I'll be happy to help!


@mlpierce22 mlpierce22 force-pushed the codex/add-flush_immediately-to-config-scaffold branch from b0bb605 to 238a6e2 Compare July 22, 2025 01:43
Ensure all example config files have flush_immediately: true
set as default to prevent data loss for files that were
moved/deleted on main branch.
Add missing flush_immediately property to TrainloopConfig types in:
- TypeScript: TrainloopConfig.trainloop.flush_immediately (optional boolean)
- Python: TrainLoopConfigObject.flush_immediately (optional boolean)

Resolves TypeScript compilation errors when accessing flush_immediately
from config objects. Go SDK already had this field defined correctly.
@mlpierce22 mlpierce22 merged commit 0d5e8c2 into main Jul 22, 2025
5 checks passed
@mlpierce22 mlpierce22 deleted the codex/add-flush_immediately-to-config-scaffold branch July 22, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 participant