Conversation
Tasks: - Fix rsa_cipher tests. - Remove rsa_cipher_big and sbom. - go fmt everything.
siriak
requested changes
Aug 27, 2021
siriak
left a comment
siriak
left a comment
Member
There was a problem hiding this comment.
Please update spacing consistently
siriak
approved these changes
Aug 27, 2021
Member
|
(Not necessarily for this PR but...) is there a way to fail GitHub Actions if code is not go fmt-ed? Other language repos enforce formatting to get contributors used to that being a requirement of their submissions. |
Member
Author
Member
|
I think this should do that already |
Member
|
It doesn't, we need to add |
Member
|
If this is already done in our GitHub Actions then why did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks:
rsa_ciphertests.rsa_cipher_bigandsbom.go fmteverything.