Security: Sensitive Data Exposure in Error Response#238
Open
tomaioo wants to merge 1 commit into
Open
Conversation
In api_server_main.py, the exception handler returns full stack traces (traceback.format_exception) in the JSON response to clients. This exposes internal application details, file paths, and potentially sensitive configuration information. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Sensitive Data Exposure in Error Response
Problem
Severity:
High| File:api_server_main.py:L36In api_server_main.py, the exception handler returns full stack traces (traceback.format_exception) in the JSON response to clients. This exposes internal application details, file paths, and potentially sensitive configuration information.
Solution
Return a generic error message to clients in production. Only log the full stack trace server-side. Consider using a separate error code that clients can use to look up details in documentation or a separate logging system.
Changes
api_server_main.py(modified)