Skip to content

fix: serialize queryKey #9308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix: serialize queryKey #9308

wants to merge 12 commits into from

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Jun 24, 2025

Serialize query keys

Should fix trpc/trpc#6802
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fbd2888.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 10s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-25 19:21:29 UTC
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 24, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9308

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9308

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9308

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9308

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9308

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9308

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9308

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9308

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9308

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9308

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9308

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9308

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9308

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9308

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9308

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9308

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9308

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9308

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9308

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9308

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9308

commit: fbd2888
@KATT KATT marked this pull request as ready for review June 24, 2025 12:34
@KATT KATT marked this pull request as draft June 24, 2025 14:47
@KATT KATT marked this pull request as ready for review June 25, 2025 19:17
KATT
KATT commented Jun 25, 2025
View reviewed changes
packages/query-core/src/__tests__/hydration.test.tsx
Comment on lines -1223 to -1228
expect(serializeDataMock).toHaveBeenCalledTimes(1)
expect(serializeDataMock).toHaveBeenCalledWith(0)

expect(deserializeDataMock).toHaveBeenCalledTimes(1)
expect(deserializeDataMock).toHaveBeenCalledWith(0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these as the test isn't about whether if serialization is about and the amount of times the mock gets called doubled so it gets a bit weird and unintuitive anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: query-core
1 participant
@KATT