refactor(angular-query): build with vite, publish d.ts files to package root #9292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit cbf31f5.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9292 +/- ##
=======================================
Coverage 45.37% 45.37%
=======================================
Files 207 207
Lines 8277 8277
Branches 1872 1870 -2
=======================================
Hits 3756 3756
Misses 4080 4080
Partials 441 441 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite allows for more flexibility in the build process.
Adds prepack script to copy a modified
package.jsonandREADME.mdto dist.The dist directory is then a usuable source directory for publishing a package with type declaration files in its root - or the relevant path for subpath exports. This is a prerequisite to support subpath exports while also supporting applications using
"moduleResolution": "node"- which is still quite common.Also fixes resolving types in applications configured with the rarely used
"moduleResolution": "node16"TypeScript setting.