perf(query-core): clear query's revertState once fetching ends successfully #9265
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sfully revertState is used as a fallback for fetching failure. Clearing it once fetching ends successfully improve memory usage, particularly with queries returning large amount of data.
TkDodo
approved these changes
Jun 19, 2025
|
View your CI Pipeline Execution ↗ for commit 4f69310.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9265 +/- ##
===========================================
+ Coverage 45.37% 59.69% +14.31%
===========================================
Files 207 136 -71
Lines 8276 5515 -2761
Branches 1870 1486 -384
===========================================
- Hits 3755 3292 -463
+ Misses 4080 1925 -2155
+ Partials 441 298 -143 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#revertStateattribute of theQueryclass is used as a fallback for fetching failure.Clearing it once fetching ends successfully improve memory usage, particularly with queries returning large amount of data.
More context in this discussion: #9264
NB: I didn't add unit tests for this modification. Indeed, as
#revertStateis a hash private attribute, I see no way to access it in unit tests to check if it is properly reset.