refactor: integrate util "noop" function in each packages #9125

novice0840 · 2025-05-08T12:41:28Z

I integrated util function "noop". The function "noop" is already made in "query-core" package. So, we don't need to make again in "react-query" package

Summary by CodeRabbit

Refactor
- Consolidated the internal no-op utility to the shared core across Angular, Solid, Svelte, and persister packages for consistency. No behavior or public API changes.
Chores
- Bumped @tanstack/query-async-storage-persister to 5.85.5.
Notes
- No user-facing changes; apps should behave exactly the same.
- Improves internal consistency and maintainability without altering existing functionality.

nx-cloud · 2025-05-08T12:41:54Z

View your CI Pipeline Execution ↗ for commit 0e1ae69

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 33s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	4s	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-31 06:36:49 UTC

…40/query into refactor/integrate-noop

pkg-pr-new · 2025-05-08T13:35:00Z

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9125

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9125

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9125

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9125

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9125

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9125

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9125

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9125

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9125

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9125

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9125

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9125

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9125

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9125

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9125

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9125

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9125

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9125

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9125

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9125

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9125

commit: 0e1ae69

codecov · 2025-05-08T13:48:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.84%. Comparing base (379670d) to head (0e1ae69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9125       +/-   ##
===========================================
+ Coverage   45.17%   86.84%   +41.66%     
===========================================
  Files         208        1      -207     
  Lines        8327       38     -8289     
  Branches     1886       10     -1876     
===========================================
- Hits         3762       33     -3729     
+ Misses       4118        5     -4113     
+ Partials      447        0      -447

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`86.84% <ø> (+2.22%)`	⬆️
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`∅ <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`∅ <ø> (∅)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TkDodo

please revert the changes to package-lock, other than that, this should be good to be merged

TkDodo · 2025-08-19T10:21:32Z

pnpm-lock.yaml

there shouldn’t be any changes in package-lock if there are no changes in package.json

Hello, I deleted all changes in "package.json" file. Please check and tell me if there is some problem

My code is already applied by other person. So this PR is not needed anymore. I'm gonna close my PR

coderabbitai · 2025-08-30T07:24:13Z

Walkthrough

The changeset centralizes usage of a noop utility by importing it from @tanstack/query-core across multiple packages, removing local noop implementations. One package version is bumped. Minor typing is added for an unsubscribe variable. No control flow or public API signatures are altered.

Changes

Cohort / File(s)	Summary of edits
Angular Query Experimental `packages/angular-query-experimental/src/inject-mutation.ts`, `packages/angular-query-experimental/src/providers.ts`, `packages/angular-query-experimental/src/util/index.ts`	Switch noop import to `@tanstack/query-core`; remove local noop export/usage; delete `util/index.ts` noop export.
Solid Query `packages/solid-query/src/useMutation.ts`, `packages/solid-query/src/useQueries.ts`, `packages/solid-query/src/utils.ts`	Import noop from core; remove local noop export; add explicit type `(() => void)` to `unsubscribe` initialization.
Svelte Query `packages/svelte-query/src/createBaseQuery.ts`, `packages/svelte-query/src/createMutation.ts`, `packages/svelte-query/src/createQueries.ts`, `packages/svelte-query/src/utils.ts`	Import noop from core and drop from local utils; keep `isSvelteStore` import; remove local noop export.
Sync Storage Persister `packages/query-sync-storage-persister/src/index.ts`, `packages/query-sync-storage-persister/src/utils.ts`	Change noop import to core; delete local noop declarations and implementation.
Async Storage Persister (metadata) `packages/query-async-storage-persister/package.json`	Bump version `5.76.0` → `5.85.5`; no code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I tidied my burrow, hop by hop,
Gathering noops into one cozy shop.
Local echoes hushed, the core now sings,
Version bumps flutter on gentle wings.
With whiskers twitching, I press “merge” — plop! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d5a9a8 and d1c98bf.

📒 Files selected for processing (1)

packages/query-async-storage-persister/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/query-async-storage-persister/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Test

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

novice0840 added 2 commits May 8, 2025 21:29

refactor: remove "noop" in "angular-query-experimental" package

04ad78a

refactor: remove unnecessary "noop" function

f02ea40

github-actions bot added package: query-core package: solid-query package: svelte-query package: angular-query-experimental labels May 8, 2025

autofix-ci bot and others added 3 commits May 8, 2025 12:42

ci: apply automated fixes

a7625ea

refactor: remove all noop expect which in query-core package

b8029e4

Merge branch 'refactor/integrate-noop' of https://github.com/novice08…

0243737

…40/query into refactor/integrate-noop

github-actions bot added package: query-async-storage-persister package: query-sync-storage-persister labels May 8, 2025

fix(solid-query): plus noop type

da78f8e

novice0840 added 2 commits May 8, 2025 22:40

fix: fix import error

26921c4

fix(query-async-storage-persister): sort dependencies alphabetically

b3629f7

novice0840 and others added 3 commits May 9, 2025 21:45

fix: resolve git conflict

af12a85

fix: remove unused files

3251575

Merge branch 'main' into refactor/integrate-noop

0ca5cee

github-actions bot removed the package: query-core label May 12, 2025

fix: resolve import error

e646812

TkDodo reviewed Aug 19, 2025

View reviewed changes

novice0840 force-pushed the refactor/integrate-noop branch from 2d5a9a8 to e646812 Compare August 30, 2025 07:28

novice0840 and others added 4 commits August 30, 2025 16:33

fix: recover pnpm-lock file

dd74171

fix: recover query-async-storage-persister package

9cb62ab

fix: "@tanstack/query-async-storage-persister" version

d1c98bf

Merge branch 'main' into refactor/integrate-noop

0e1ae69

novice0840 closed this Aug 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: integrate util "noop" function in each packages #9125

refactor: integrate util "noop" function in each packages #9125

Uh oh!

novice0840 commented May 8, 2025 •

edited by coderabbitai bot

Loading

nx-cloud bot commented May 8, 2025 •

edited

Loading

pkg-pr-new bot commented May 8, 2025 •

edited

Loading

codecov bot commented May 8, 2025 •

edited

Loading

TkDodo left a comment

TkDodo Aug 19, 2025

novice0840 Aug 30, 2025

novice0840 Aug 31, 2025

coderabbitai bot commented Aug 30, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

refactor: integrate util "noop" function in each packages #9125

refactor: integrate util "noop" function in each packages #9125

Uh oh!

Conversation

novice0840 commented May 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

nx-cloud bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

pkg-pr-new bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

codecov bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

TkDodo left a comment

Choose a reason for hiding this comment

TkDodo Aug 19, 2025

Choose a reason for hiding this comment

novice0840 Aug 30, 2025

Choose a reason for hiding this comment

novice0840 Aug 31, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

novice0840 commented May 8, 2025 •

edited by coderabbitai bot

Loading

nx-cloud bot commented May 8, 2025 •

edited

Loading

pkg-pr-new bot commented May 8, 2025 •

edited

Loading

codecov bot commented May 8, 2025 •

edited

Loading

coderabbitai bot commented Aug 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)