Skip to content

Add KeyDB global variable to lua api #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msotheeswaran-sc merged 7 commits into from
Mar 14, 2023
Merged

Add KeyDB global variable to lua api #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d7dbc9
attempt to add KeyDB global var to lua
msotheeswaran-sc Mar 14, 2023
b70e861
unit test for KeyDB var
msotheeswaran-sc Mar 14, 2023
7e9188a
assert that redis and KeyDB vars return same value
msotheeswaran-sc Mar 14, 2023
1b44a45
wrong brackets
msotheeswaran-sc Mar 14, 2023
36f4735
change test name
msotheeswaran-sc Mar 14, 2023
370dd55
add comment
msotheeswaran-sc Mar 14, 2023
5516ed5
keydb instead of KeyDB
msotheeswaran-sc Mar 14, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/scripting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,6 +1264,9 @@ void scriptingInit(int setup) {

/* Finally set the table as 'redis' global var. */
lua_setglobal(lua,"redis");
/* Set table as 'keydb' global var as well */
lua_getglobal(lua,"redis");
lua_setglobal(lua,"keydb");

/* Replace math.random and math.randomseed with our implementations. */
lua_getglobal(lua,"math");
Expand Down
7 changes: 6 additions & 1 deletion tests/unit/scripting.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,15 @@ start_server {tags {"scripting"}} {
r eval {return redis.call('get',KEYS[1])} 1 mykey
} {myval}

test { EVAL - keys command works? } {
test {EVAL - keys command works? } {
r eval {return redis.call('keys', 'test')} 0
}

test {EVAL - KeyDB global works } {
r eval {return keydb.call('get', KEYS[1])} 1 mykey
assert_equal [r eval {return redis.call('get',KEYS[1])} 1 mykey] [r eval {return keydb.call('get', KEYS[1])} 1 mykey]
}

test {EVALSHA - Can we call a SHA1 if already defined?} {
r evalsha fd758d1589d044dd850a6f05d52f2eefd27f033f 1 mykey
} {myval}
Expand Down