Validate string#434
Open
chris124567 wants to merge 2 commits into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
chris124567
requested review from
Alrighttt,
ChrisSchinnerl,
lukechampine and
n8mgr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds basic validation for peer address strings before they are persisted to the peer store during peer discovery, preventing obviously malformed host:port entries from being recorded.
Changes:
- Added
validatePeer(addr string) errorto validatehost:portformatting and port range. - Updated peer discovery to ignore (and log) invalid addresses returned by the
ShareNodesRPC. - Added
strconvimport to support port parsing.
Note: This repo contains knope.toml; consider adding an appropriate changeset file for this behavioral change.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.