Skip to content

Struct like ColumnType::Enum variant & store String in DynIden #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2022
Merged

Struct like ColumnType::Enum variant & store String in DynIden #435

merged 2 commits into from
Sep 20, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Sep 7, 2022 •
edited
Loading

PR Info

Breaking Changes

  • ColumnType::Enum variant is a struct variant, it used to be tuple variant
  • ColumnDef::enumeration() method now take parameters impl IntoIden, it used to take String

Changes

  • ColumnDef::custom() method now take parameters impl IntoIden, it used to take Iden
@billy1624 billy1624 self-assigned this Sep 7, 2022
@billy1624 billy1624 marked this pull request as ready for review September 7, 2022 10:37
ikrivosheev
ikrivosheev approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 thank you! LGTM!
@tyt2y3 tyt2y3 merged commit 7f4982d into master Sep 20, 2022
@tyt2y3 tyt2y3 deleted the rewrite-column-ty-enum branch September 20, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@billy1624 @ikrivosheev @tyt2y3