Skip to content

Sqlite Drop Index #461

Closed
Closed
@baszalmstra

Description

@baszalmstra

Description

When dropping an index with SQLite invalid SQL is generated.

Sqlite doest accept an ON as can be seen here.

Steps to Reproduce

println("{}", Index::drop().name("idx_unique_foo").build(SqliteQueryBuilder));

results in:

DROP INDEX "idx_unique_foo" ON 

which is invalid SQL.

Adding a table also generates invalid SQL for SQLite:

 Index::drop().name("idx_unique_foo").table(Foo::Table).build(SqliteQueryBuilder)
DROP INDEX "idx_unique_foo" ON "foo"

Expected Behavior

I would expect the ON part to not be present.

Actual Behavior

See above

Reproduces How Often

Always

Versions

├── sea-orm v0.9.2
│   ├── sea-orm-macros v0.9.2 (proc-macro)
│   ├── sea-query v0.26.3
│   │   ├── sea-query-derive v0.2.0 (proc-macro)
│   │   ├── sea-query-driver v0.2.2 (proc-macro)
│   ├── sea-strum v0.23.0
│   │   └── sea-strum_macros v0.23.0 (proc-macro)
├── sea-orm-migration v0.9.2
│   ├── sea-orm v0.9.2 (*)
│   ├── sea-orm-cli v0.9.2
│   │   ├── sea-schema v0.9.3
│   │   │   ├── sea-query v0.26.3 (*)
│   │   │   └── sea-schema-derive v0.1.0 (proc-macro)
│   ├── sea-schema v0.9.3 (*)

Additional Information

Ill create a PR to fix this.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions