chore: apply unreachable_pub lint
#1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
commented
Sep 16, 2025
Member
|
@TomAFrench can you rebase? It looks like there's a test failure, but I think the related code has also changed |
TomAFrench
force-pushed
the
tf/restrict-visibility
branch
from
cfb2454 to
63d8a47
Compare
Contributor
Author
|
Done! |
Member
|
Hmm, still one failure at: ecdsa/src/dev.rs:227:17 |
Contributor
Author
|
huh, this was passing locally. Will take another look. |
Contributor
Author
|
all good now! |
tarcieri
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on with updates started in RustCrypto/hashes#734. Still needs a couple of crates to be dealt with.