Skip to content

Fix MpscLinkedQueue GC issues #7799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Fix MpscLinkedQueue GC issues #7799

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8582b9
Refactor MpscLinkedQueue.poll
olivergillespie Nov 21, 2024
4c6c6fa
Unlink dead nodes in MpscLinkedQueue
olivergillespie Nov 21, 2024
43a7cf7
Revert "Unlink dead nodes in MpscLinkedQueue"
olivergillespie Nov 21, 2024
d51d3ff
Revert "Refactor MpscLinkedQueue.poll"
olivergillespie Nov 21, 2024
898c19d
Unlink dead nodes in MpscLinkedQueue
olivergillespie Nov 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/io/reactivex/rxjava3/internal/queue/MpscLinkedQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ public T poll() {
// we have to null out the value because we are going to hang on to the node
final T nextValue = nextNode.getAndNullValue();
spConsumerNode(nextNode);
// unlink previous consumer to help gc
currConsumerNode.soNext(null);
return nextValue;
}
else if (currConsumerNode != lvProducerNode()) {
Expand All @@ -101,6 +103,8 @@ else if (currConsumerNode != lvProducerNode()) {
// we have to null out the value because we are going to hang on to the node
final T nextValue = nextNode.getAndNullValue();
spConsumerNode(nextNode);
// unlink previous consumer to help gc
currConsumerNode.soNext(null);
return nextValue;
}
return null;
Expand Down
Loading