Fix parsing of the comma-separated membershipIds query param#131
Open
lildeadprince wants to merge 2 commits into
Open
Fix parsing of the comma-separated membershipIds query param#131lildeadprince wants to merge 2 commits into
membershipIds query param#131lildeadprince wants to merge 2 commits into
Conversation
lildeadprince
force-pushed
the
fix/instance-finder-membership-ids
branch
from
16b9f7b to
ddddc86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instance Finder API does not correctly preprocess
membershipIdscomma-separated string due to wrong Zod schema implementation.z.preprocess(since it returnsZodEffectinstead of a type)`z.array(z.preprocess(...))` expects an array an fails on string input
"Profile/Instance Finder" fails on any query containing another IDs `https://api.raidhub.io/player//instances?membershipIds=`