fix build on macOS when Metal is disabled#196
Open
LoganDark wants to merge 1 commit into
Open
Conversation
ggml-blas was only linked and had PIC set inside the GGML_METAL condition, but on macOS, ggml enables the BLAS backend by default (via Accelerate) regardless of whether Metal is enabled. This caused an undefined symbol error for ggml_backend_blas_reg at link time. Decouple ggml-blas from the Metal condition by using `if (TARGET ggml-blas)` instead, which correctly handles all cases: macOS with or without Metal, Linux with OpenBLAS, and platforms without BLAS. Co-authored-by: Claude Signed-off-by: LoganDark <4723091+LoganDark@users.noreply.github.com>
LoganDark
force-pushed
the
cmake-ggml-blas
branch
from
d9835e4 to
ddf62b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ggml-blas was only linked and had PIC set inside the GGML_METAL condition, but on macOS, ggml enables the BLAS backend by default (via Accelerate) regardless of whether Metal is enabled. This caused an undefined symbol error for ggml_backend_blas_reg at link time.
Decouple ggml-blas from the Metal condition by using
if (TARGET ggml-blas)instead, which correctly handles all cases: macOS with or without Metal, Linux with OpenBLAS, and platforms without BLAS.