-
Notifications
You must be signed in to change notification settings - Fork 886
foot note adjustments #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a config to set the footnote separator. Also remove rel/rev as they aren't really compatible with HTML5 and we already have classes set for refs and backrefs.
tests/test_extensions.py
Outdated
| '</div>' | ||
| ) | ||
|
|
||
| def testFootnoteSeparator(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this new test using the new testing framework. Ideally the existing tests should be moved as well. But I'll settle for the new one only for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll most likely move all footnote tests in this file to the new format.
|
Requested changes have been made. |
|
Out of curiosity, is there an ETA for when a release containing this fix will be pushed out? |
|
I am hoping soon, not specifically for this issue, but for the code escape issue: #725. |
|
I expect a release once #732 is finalized (which includes some maintenance to bring the repo inline with the guidelines). Note that this adds a feature, so this cannot be part of a bugfix release, but will be a point release (3.1). Therefore, it is a little slower moving. |
|
@waylan: Any chance that a v3.0.2 release could be published sooner that contains the aforementioned fixes? (i.e., without new features) |
|
@justinmayer that is a valid question. However, the effort to backport the bugfixes and the effort to finalize 3.1 are probably about the same. Therefore, I think it makers more sense to move forward with 3.1. It's just the matter of finding the time. |
Add a config to set the footnote separator. Also remove rel/rev as they aren't really compatible with HTML5 and we already have classes set for refs and backrefs. Ref #723.