Skip to content

Conversation

@facelessuser
Copy link
Collaborator

Add a config to set the footnote separator. Also remove rel/rev as they aren't really compatible with HTML5 and we already have classes set for refs and backrefs. Ref #723.

Add a config to set the footnote separator. Also remove rel/rev as they aren't really compatible with HTML5 and we already have classes set for refs and backrefs.
'</div>'
)

def testFootnoteSeparator(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this new test using the new testing framework. Ideally the existing tests should be moved as well. But I'll settle for the new one only for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll most likely move all footnote tests in this file to the new format.

@facelessuser
Copy link
Collaborator Author

Requested changes have been made.

@waylan waylan merged commit 908bd07 into Python-Markdown:master Oct 9, 2018
@minchinweb
Copy link

Out of curiosity, is there an ETA for when a release containing this fix will be pushed out?

@facelessuser
Copy link
Collaborator Author

I am hoping soon, not specifically for this issue, but for the code escape issue: #725.

@waylan
Copy link
Member

waylan commented Oct 17, 2018

I expect a release once #732 is finalized (which includes some maintenance to bring the repo inline with the guidelines).

Note that this adds a feature, so this cannot be part of a bugfix release, but will be a point release (3.1). Therefore, it is a little slower moving.

@justinmayer
Copy link

@waylan: Any chance that a v3.0.2 release could be published sooner that contains the aforementioned fixes? (i.e., without new features)

@waylan
Copy link
Member

waylan commented Oct 17, 2018

@justinmayer that is a valid question. However, the effort to backport the bugfixes and the effort to finalize 3.1 are probably about the same. Therefore, I think it makers more sense to move forward with 3.1. It's just the matter of finding the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants