open: allow bareword args for all dup modes #22552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only ">&" used to exempt the third open argument from
"strict subs":
use strict;
open my $fh1, ">&", STDOUT; # bareword allowed
open my $fh2, ">>&", STDOUT; # error: Bareword "STDOUT" not allowed
Now all dup modes (>&, >>&, <&, +>&, +>>&, +<&) allow bareword
filehandles.
Fixes Perl#22464.
Previously, only ">&" was tested (and other modes didn't work). Now all 6 dup modes are tested (and 6 non-dup modes to verify that barewords are still disallowed otherwise).
tonycoz
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only ">&" used to exempt the third open argument from
"strict subs":
Now all dup modes (>&, >>&, <&, +>&, +>>&, +<&) allow bareword
filehandles.
Fixes #22464.