Skip to content

Allow can() to take a list of methods #22405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ovid wants to merge 5 commits into from
Closed

Allow can() to take a list of methods #22405

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9784e88
Update UNIVERSAL::can() to accept a list of methods to check for
Ovid Jul 14, 2024
59dfd9f
no need to iterate over our args twice.
Ovid Jul 14, 2024
a0a3c76
Add me to AUTHORS
Ovid Jul 14, 2024
4795c9c
Make sure we extend the stack before we start modifying it
Ovid Jul 15, 2024
f2b6d8f
Return nothing, instead of undef, when can() is called with missing m…
Ovid Jul 15, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make sure we extend the stack before we start modifying it
  • Loading branch information
@Ovid
Ovid committed Jul 15, 2024
commit 4795c9c46b6fe751909dd3751098ea688b836688
2 changes: 1 addition & 1 deletion universal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,7 @@ XS(XS_UNIVERSAL_can)
}

if (pkg) {
EXTEND(SP, items - 1);
for (i = 1; i < items; i++) {
GV * const gv = gv_fetchmethod_sv_flags(pkg, ST(i), 0);
if (!gv || !isGV(gv) || !GvCV(gv))
Expand All @@ -516,7 +517,6 @@ XS(XS_UNIVERSAL_can)
ST(i-1) = sv_2mortal(newRV(MUTABLE_SV(GvCV(gv))));
}
}
EXTEND(SP, items - 1);
XSRETURN(items - 1);
}

Expand Down