ASE-275: tighten frontend mock-api budget debt#761
Open
BetterAndBetterII wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
web/src/lib/testing/e2e/mock-apisupport modules into focused seed, route, ticket-record, project-update, and ticket-runtime helpersweb/file-budgets.config.mjsandweb/README.mdWhy
ASE-275 targets temporary frontend debt that was introduced to get past file-length budget checks. The E2E mock-API support layer had grown large enough to require an unusually broad testing-support budget, so this PR pays that debt down by splitting the hotspots into maintainable modules and then narrowing the allowed budget again.
Impact
Validation
cd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm install --frozen-lockfilecd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm run format:checkcd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm run lintcd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm run lint:structurecd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm run lint:depscd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm exec vitest run src/lib/testing/e2e/mock-api/entities.test.ts src/lib/testing/e2e/mock-api/initial-state.test.ts src/lib/testing/e2e/mock-api/project-update-records.test.ts src/lib/testing/e2e/mock-api/ticket-runtime-data.test.tscd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm exec svelte-check --tsconfig ./tsconfig.json --output machine --threshold errorcd web && PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PATH pnpm exec vite build --logLevel warn