Retire legacy workflow/schema compat read paths#686
Open
BetterAndBetterII wants to merge 4 commits into
Open
Conversation
Summary: - move workflow metadata backfill out of workflow repo read paths and into the explicit startup migration flow in database.Open - keep schema bootstrap DDL preparation, but rename it around startup preparation instead of scattered legacy compat wording - narrow provider secret_bindings to explicit refs only while keeping a separate legacy inline inventory path for migration hygiene - add startup migration coverage for workflow metadata and update provider binding tests to assert the new single truth path Rationale: - normal workflow reads should not mutate stored data or hide migration work behind incidental fetches - provider secret_bindings should describe real binding truth instead of wrapping legacy inline auth_config secrets as if they were bindings - startup remains the safest retained migration point because populated databases still need pre-schema backfill before current constraints apply Tests: - go test ./internal/domain/catalog ./internal/runtime/database ./internal/repo/workflow - go test ./internal/runtime/... ./internal/repo/workflow ./internal/service/... ./internal/httpapi Co-authored-by: Codex <codex@openai.com>
Summary: - add direct coverage for legacy inline provider inventory and overlap filtering helpers - remove an unreachable guard in LegacyAgentProviderSecretBindings so the domain/core coverage gate matches real behavior Rationale: - the repo CI gate requires 100% domain/core coverage - explicit binding cleanup should stay fully covered so the new source of truth does not regress behind the migration hygiene path Tests: - go test ./internal/domain/catalog - go test ./internal/runtime/... ./internal/repo/workflow ./internal/service/... ./internal/httpapi Co-authored-by: Codex <codex@openai.com>
Summary: - run the explicit workflow metadata migration after seeding legacy workflow version content in runtime launcher tests - keep orchestrator fixtures aligned with the new ASE-184 startup-only migration path instead of relying on removed read-time fallback Rationale: - the ASE-184 cleanup moved workflow metadata migration out of normal repository reads and into explicit startup migration entrypoints - runtime launcher tests seed legacy data directly and must now invoke that migration themselves before validating harness content Tests: - PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$HOME/.local/go1.26.1/bin:$PATH OPENASE_PGTEST_SHARED_ROOT=$HOME/.cache/openase/pgtest OPENASE_GO_TEST_PROGRESS_MODE=json .codex/skills/push/scripts/openase_ci_gate.sh Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
PATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PWD/.tooling/go/bin:$HOME/.local/go1.26.1/bin:$PATH go test ./internal/runtime/... ./internal/repo/workflow ./internal/service/... ./internal/httpapiPATH=$HOME/.nvm/versions/node/v22.22.1/bin:$PWD/.tooling/go/bin:$HOME/.local/go1.26.1/bin:$PATH go test ./internal/domain/catalog ./internal/runtime/database ./internal/repo/workflowPATH=$HOME/.nvm/versions/node/v22.22.1/bin:$HOME/.local/go1.26.1/bin:$PATH OPENASE_PGTEST_SHARED_ROOT=$HOME/.cache/openase/pgtest OPENASE_GO_TEST_PROGRESS_MODE=json .codex/skills/push/scripts/openase_ci_gate.shRisks / Follow-up
ticket_agentscope in this runtime cannot mutate repo-scope bindings;openase repo scope ...currently returnsHUMAN_SESSION_REQUIRED, so this PR is linked back to the ticket through an external link/workpad note instead.