v3.2: Provide guidance for the Set-Cookie
response header
#4748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses issue #1237
The Set-Cookie response header breaks the normal rules for headers with multiple values and requires special handling.
There are two options here:
Set-Cookie
in a consistent mannerSet-Cookie
as a special case and define how it relates to normal behaviorSince RFC9110 §5.3 advises clients to treat
Set-Cookie
as a special case, I went with special-casing it. This assumes the approach to header serialization that is described in PR #4648 and discussed in one of its comment threads (specifically, that it does not include the header name which is required for it to be consistent with howstyle: "simple"
andexplode
are treated elsewhere and are defined in RFC6570).