Adds a wrapper for RMSE calculated using the scores package#2107
Draft
David Flack (daflack) wants to merge 10 commits into
Draft
Adds a wrapper for RMSE calculated using the scores package#2107David Flack (daflack) wants to merge 10 commits into
David Flack (daflack) wants to merge 10 commits into
Conversation
Contributor
May decide to template these variables for ease of use or create a rotated vs unrotated pole version
7527019 to
5fe4065
Compare
Collaborator
Author
|
last two tests are currently repeats of the equivalent version in the difference. However, the difference plot uses .data and so whilst the data is flipped the coordinates are not flipped. Here we need both the data and the coordinates flipped otherwise we cannot collapse for timeseries or spatial maps. I need to test what happens if we don't flip the grids before putting it through scores. Worst case scenario we would need to remake the cube with correct data. Or would regridding the cube onto the other cube help with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2105
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.