Skip to content

build: fix ubuntu 24.04 deps#2374

Merged
ReenigneArcher merged 1 commit into
nightlyfrom
build-fix-ubuntu-24.04-deps
Apr 6, 2024
Merged

build: fix ubuntu 24.04 deps#2374
ReenigneArcher merged 1 commit into
nightlyfrom
build-fix-ubuntu-24.04-deps

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Remove libavdevice-dev as a build dep. What is this even used for?

Also, update docker ignore file.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated
@ReenigneArcher ReenigneArcher added this to the v0.23.0 milestone Apr 6, 2024
@codecov

codecov Bot commented Apr 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.40%. Comparing base (42b4192) to head (8ce486f).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2374      +/-   ##
==========================================
- Coverage     6.50%   6.40%   -0.11%     
==========================================
  Files           85      85              
  Lines        18382   18378       -4     
  Branches      8348    8342       -6     
==========================================
- Hits          1196    1177      -19     
- Misses       16103   16189      +86     
+ Partials      1083    1012      -71     
Flag Coverage Δ
Linux 4.42% <ø> (ø)
Windows 2.00% <ø> (ø)
macOS-12 ?
macOS-13 8.08% <ø> (+0.01%) ⬆️
macOS-14 8.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@ReenigneArcher
ReenigneArcher merged commit 1ed22ab into nightly Apr 6, 2024
@ReenigneArcher
ReenigneArcher deleted the build-fix-ubuntu-24.04-deps branch April 6, 2024 01:45
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant