Skip to content

(core): fix XML configuration parsing#3

Merged
fbridault merged 2 commits into
IRCAD:devfrom
emiliehar:fix-config-parsing
Jul 1, 2021
Merged

(core): fix XML configuration parsing#3
fbridault merged 2 commits into
IRCAD:devfrom
emiliehar:fix-config-parsing

Conversation

@emiliehar
Copy link
Copy Markdown
Contributor

Description

Fix the parsing of object containing sub-object (like Composite) or values (like String).
Also fix the pasing of service with an external configuration ("config" tag in the XML service definition).

How to test it?

  • Launch unit tests.
  • Try to add config="..." in a service with inputs (like a reader).
  • Try to use a Composite with sub-object (like composite of transfer functions).
@emiliehar emiliehar force-pushed the fix-config-parsing branch 2 times, most recently from ab9b094 to 9d3a867 Compare June 11, 2021 14:35
Fix the parsing of object containing sub-object (like Composite) or values (like String).
Also fix the pasing of service with an external configuration ("config" tag in the XML service definition).
@emiliehar emiliehar force-pushed the fix-config-parsing branch from 9d3a867 to 3370e05 Compare June 11, 2021 14:41
@fbridault fbridault merged commit 7889755 into IRCAD:dev Jul 1, 2021
@fbridault
Copy link
Copy Markdown
Member

The pipeline passed upstream on git.ircad.fr.
This works fine, thanks a lot for the fix!

fbridault pushed a commit that referenced this pull request Jul 1, 2021
Fix the parsing of objects containing sub-object (like Composite) or values (like String).
Also fix the parsing of service with an external configuration ("config" tag in the XML service definition).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants