Skip to content

perl 5.38.0 #145939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Sep 28, 2023
Merged

perl 5.38.0 #145939

merged 26 commits into from
Sep 28, 2023

Conversation

briandfoy
Copy link
Contributor

Created with brew bump-formula-pr.
@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` autosquash Automatically squash pull request commits according to Homebrew style. labels Sep 25, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 25, 2023
@p-linnane
Copy link
Member

Please squash your commits into one with the message perl 5.38.0. Thanks.
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 25, 2023
@SMillerDev
Copy link
Member

Dropped the merge commit that didn't need to be there.
@briandfoy
Copy link
Contributor Author

It looks like the failed tests are all the deps checks. Several formula depend on the old perl@36.

What's the process when this happens? Do those need to be modified by hand or is there another automated step that should recompile them?
@p-linnane
Copy link
Member

It looks like the failed tests are all the deps checks. Several formula depend on the old perl@36.

What's the process when this happens? Do those need to be modified by hand or is there another automated step that should recompile them?

We need to do revision bumps for the affected formulae, so that they rebuild against the newest perl. I've pushed those there.
@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels Sep 26, 2023
@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 27, 2023
p-linnane
p-linnane approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution @briandfoy!
@p-linnane p-linnane added the ready to merge PR can be merged once CI is green label Sep 27, 2023
ZhongRuoyu
ZhongRuoyu approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @briandfoy and @p-linnane!
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 27, 2023
@briandfoy
Copy link
Contributor Author

briandfoy commented Sep 27, 2023 •
edited
Loading

Looking at the failures in the one failing check:

  • mnoarch tries to download https://www.mhonarc.org/release/MHonArc/tar/MHonArc-2.6.19.tar.bz2%60 but gets a 404. Remove the %60 and it's found. I don't know why that extra character is there in just one architecture.
  • asciiaquarium fails it's test because it expects to have four characters that it grabs and gets three (or something unprintable maybe). I've tried this program from 2015 (with no updates since then) on Perl v5.38 without problem. But, the asciiquarium.rb is a couple years out of date on the versions of the Perl modules this program needs.
@aferreira
Copy link

For reference: #135640 was a previous attempt to upgrade perl to 5.38.0
@chenrui333
Copy link
Member

Only on 13

brew install --verbose --build-bottle bioperl
brew test --verbose asciiquarium
brew fetch --retry mhonarc --build-bottle --force
brew install --verbose --build-bottle mhonarc
@chenrui333 chenrui333 added the 13 Ventura is specifically affected label Sep 28, 2023
@chenrui333
Copy link
Member

Thanks @briandfoy and @p-linnane! 🚢
@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 28, 2023
@p-linnane p-linnane enabled auto-merge September 28, 2023 15:19
@p-linnane p-linnane added this pull request to the merge queue Sep 28, 2023
Merged via the queue into Homebrew:master with commit 77fb280 Sep 28, 2023
@briandfoy briandfoy deleted the bump-perl-5.38.0 branch September 28, 2023 17:58
iMichka added a commit to iMichka/homebrew-core that referenced this pull request Oct 13, 2023
@iMichka
rxvt-unicode: bump revision for perl
4970fb2 
This was missed in Homebrew#145939
iMichka added a commit to iMichka/homebrew-core that referenced this pull request Oct 13, 2023
@iMichka
get_iplayer: bump revision for perl
6476068 
This was missed in Homebrew#145939
This was referenced Oct 13, 2023
Closed
Merged
Merged
chenrui333 pushed a commit to iMichka/homebrew-core that referenced this pull request Oct 14, 2023
@iMichka @chenrui333
gnumeric: bump revision for perl
7982664 
This was missed in Homebrew#145939
This was referenced Oct 16, 2023
Merged
Merged
This was referenced Oct 24, 2023
Merged
Merged
chenrui333 added a commit to chenrui333/homebrew-core that referenced this pull request Oct 26, 2023
@chenrui333
postgresql@11: revision bump (perl 5.38.0)
48feb26 
```
brew linkage --test postgresql@11
  Missing libraries:
    unexpected (libperl.so)
```

found in:
- Homebrew#152259

relates to:
- Homebrew#145939

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 mentioned this pull request Oct 26, 2023
Merged
@chenrui333 chenrui333 mentioned this pull request Oct 26, 2023
Merged
chenrui333 added a commit to chenrui333/homebrew-core that referenced this pull request Oct 26, 2023
@chenrui333
postgresql@12: revision bump (perl 5.38.0)
25142f8 
```
brew linkage --test postgresql@11
  Missing libraries:
    unexpected (libperl.so)
```

found in:
- Homebrew#152259

relates to:
- Homebrew#145939

Signed-off-by: Rui Chen <[email protected]>
chenrui333 added a commit to chenrui333/homebrew-core that referenced this pull request Oct 27, 2023
@chenrui333
postgresql@13: revision bump (perl 5.38.0)
111ca2e 
```
brew linkage --test postgresql@13
  Missing libraries:
    unexpected (libperl.so)
```

found in:
- Homebrew#152259

relates to:
- Homebrew#145939

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2023
Merged
chenrui333 added a commit to chenrui333/homebrew-core that referenced this pull request Oct 27, 2023
@chenrui333
postgresql@14: revision bump (perl 5.38.0)
cf205c9 
```
brew linkage --test postgresql@14
  Missing libraries:
    unexpected (libperl.so)
```

found in:
- Homebrew#152259

relates to:
- Homebrew#145939

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2023
Merged
chenrui333 added a commit to chenrui333/homebrew-core that referenced this pull request Oct 27, 2023
@chenrui333
postgresql@15: revision bump (perl 5.38.0)
8b682a0 
```
brew linkage --test postgresql@15
  Missing libraries:
    unexpected (libperl.so)
```

found in:
- Homebrew#152259

relates to:
- Homebrew#145939

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2023
Merged
chenrui333 added a commit to chenrui333/homebrew-core that referenced this pull request Oct 27, 2023
@chenrui333
postgresql@16: revision bump (perl 5.38.0)
c8d15f0 
```
brew linkage --test postgresql@15
  Missing libraries:
    unexpected (libperl.so)
```

found in:
- Homebrew#152259

relates to:
- Homebrew#145939

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13 Ventura is specifically affected bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing ready to merge PR can be merged once CI is green
6 participants
@briandfoy @p-linnane @SMillerDev @aferreira @chenrui333 @ZhongRuoyu