Skip to content

Improve formula not found handling #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2016
Merged

Improve formula not found handling #96

merged 1 commit into from
Aug 10, 2016

Conversation

mistydemeo
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran brew tests with your changes locally?

As pointed out by a user on twitter, our formula-not-found error handling could stand to be a bit clearer.
@dunn
Copy link
Contributor

dunn commented Apr 16, 2016

🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶 🐶
@MikeMcQuaid
Copy link
Member

:shipit: 👍 🐶 🐕 🐩
xu-cheng
xu-cheng reviewed Apr 16, 2016
View reviewed changes
Library/Homebrew/cmd/install.rb
if (blacklist = blacklisted?(e.name))
ofail "#{e.message}\n#{blacklist}"
elsif e.name == "updog"
ofail "What's updog?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to ask whether it's better to put this Easter egg into blacklist rather than a separate if else branch.
@MikeMcQuaid
Copy link
Member

@mistydemeo Any thoughts on @xu-cheng's comment here?
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label May 22, 2016
@MikeMcQuaid MikeMcQuaid merged commit fdf55e7 into Homebrew:master Aug 10, 2016
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label Aug 10, 2016
@arthurnn
Copy link

🐶
@zmwangx
Copy link
Contributor

zmwangx commented Sep 21, 2016

Locking conversation to avoid attracting more dog emojis.
@Homebrew Homebrew locked and limited conversation to collaborators Sep 21, 2016
@mistydemeo mistydemeo deleted the updog branch January 30, 2017 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
7 participants
@mistydemeo @dunn @MikeMcQuaid @arthurnn @zmwangx @xu-cheng @BrewTestBot