-
Notifications
You must be signed in to change notification settings - Fork 29
Manufacturing impacts backend #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evenmatencio
wants to merge
29
commits into
GreenAlgorithms:master
Choose a base branch
from
evenmatencio:feature-manufacturing-abiotic-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Manufacturing impacts backend #56
evenmatencio
wants to merge
29
commits into
GreenAlgorithms:master
from
evenmatencio:feature-manufacturing-abiotic-backend
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… die area + first manufacturing coputation for CPU
…ting some processing to the new data structure
…s, so completed now. Need to check and debug with google sheet
- satisfying frontend for all zoom levels - calculator backend working but no retro-compatibility with previous data versions: FIX needed - tests with export csv were not perforemed because of that
…formed yet. Retrocompatibility with previous data versions (inputs and imported csv) to be implemented
- data and imported csv retro-compatibility is satisfying, - terminology: manufacturing instead of embodied, - all 9 tests from csv run correctly
…roxy for the real condition ton test
…et as there is no frontend for it
…t hardcoded anymore
- increased readlibility (css improvements) - more detailed message (distincition between missing inputs and other kinds of errors) - csv exported from an old version of the calculator detected
- a subform is shown when the custom option is selected, - apropriate tests are performed on the imported value
- changing Both into CPU + GPU, - addind unit to custom CI title
This was referenced Jun 20, 2025
- WARNING: the base impact for ADP is replaced by a null value, was negative otherwise
…vated by translation that cannot work otherwise. We apply this refactorization to this branch to ease future merge
…s is motivated by translation that cannot work otherwise. We apply this refactorization to this branch to ease future merge
…is motivated by translation that cannot work otherwise. We apply this refactorization to this branch to ease future merge
…otivated by translation that cannot work otherwise. We apply this refactorization to this branch to ease future merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manufacturing impacts
Description
This PR implements the computation of two manufacturing impacts: green house gases emissions (GWP, in gCO2e) and abiotic (metals and minerals) resources depletion (ADP, in kgSbe). Currently, the corresponding metrics are only available through the exported csv because the user interface for it is not implemented yet.
Methodology
The formulas and values used for manufacturing impacts rely on the methodology from the MLCA paper [1] and were jointly developed with Clément Morand.
Input data and retro-compatibility
New data files are required for this PR. This data relates to hardware impacts values for GWP and ADP. We also use new cores specifications, namely the die area and and memory for GPUs.
We did not modify the data files from previous versions. Using the previous data versions in the calculator will work the same for existing usage impacts and will return null manufacturing impacts.
Outputs
We compute the manufacturing impacts for CPUs, GPUs, memory and other devices of the selected computation platform (casing, motherboard...). These values are aggregated to produce the final impact value. As for other impacts, it works strictly the same on the home page and IA page.
Related features
Cores sub-forms
Users who want to input custom cores characteristics are now invited to select the option "I can't find my cpu/gpu". This item shows an additional sub-form with three core specs: TDP, die area and number of cores for CPUs and TDP, die area and memory for GPUs. All of them come with pre-filled average values.
CSV data files cleaned and harmonized
This was motivated by the new values used for the manufacturing impacts.
Because we need the die area that is not available for all cores, the new data comes with the following modifications of the CPU and GPU list:
New platform type: Personal workstation
The previous 'Personal computer' is now renamed as 'Personal laptop' and a new option is available: 'Personal workstation'.
This distinction is useful only for manufacturing impacts computations.
WARNING: the personal laptop base impacts for ADP is set to 0.
Other content
This PR also goes with the following improvements:
Improved error message at csv loading
Increased readability and more flexible message.
Custom carbon intensity field
The user can decide to enter a custom carbon intensity when selecting the continent of his computation, in the location section.
Adaptive cores default values
[BUGFIX] The cores default value now depends on the version.
Refactorization
We now implement blueprints as classes that inherit from the
dash_extensions.enrich.DashBlueprint
class. Blueprints do not really match the 'class-oriented development' patterns as callbacks cannot be implemented as methods but it is the solution we chose to make it compatible with the translation feature. Even if translation is not directly implemented in this PR, the refactorization will ease future merge processes.References
[1] Morand, C., Ligozat, A. L., & Névéol, A. (2024, June). Mlca: a tool for machine learning life cycle assessment. In 2024 10th International Conference on ICT for Sustainability (ICT4S) (pp. 227-238). IEEE.