bitem::parse: fixup uncaught exception.#5
Merged
Conversation
Contributor
ttys3
commented
May 30, 2019
Owner
|
Thanks for the PR! Hmmm... I think |
std::string::substr may cause std::out_of_range exception std::stoull and std::stoll may cause std::invalid_argument exception both will cause php terminated. related method: bdict::parse bint::parse bstr::parse bitem::escape_key -> used by bdict::search bitem::get_current_key -> used by bdict/blist del_path get_path set_path
a5fa0f3 to
468351e
Compare
Contributor
Author
|
I've made a macro wrap named
related method: maybe related: |
Owner
|
The macro looks good to me :) I'll publish a new release asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.