Test plugin improvements#9138
Open
rustyrussell wants to merge 3 commits into
Open
Conversation
Avoids having to create a special test plugin most of the time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Reduces the number of misc test plugins. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Replace non-standard node variable names (n, n2, node, ln) with l1/l2 across test_plugin.py and test_misc.py. Convert four tests in test_connection.py to use get_nodes() instead of consecutive get_node() calls with identical options (slightly faster). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rustyrussell
force-pushed
the
guilt/test-plugin-improvements
branch
from
06fdca4 to
49b3c00
Compare
Collaborator
|
A claude PR that removes as many lines as it adds 😲, nice. Feels much cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got Claude to neaten Python tests:
Changelog-None: tests only